Pass ArgumentAccess with the knp_pager.items event
#343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpdude
force-pushed
the
pass-argument-access
branch
from
08e5ca6
to
5cd777b
Compare
This makes it possible for `knp_pager.items` event subscribers to access the pagination parameters, without having to be wired up by a dedicated `knp_pager.before` handler.
mpdude
force-pushed
the
pass-argument-access
branch
from
5cd777b
to
6756cda
Compare
mpdude
commented
Sep 24, 2024
Comment on lines
-431
to
-438
| $requestStack = $this->createRequestStack(['filterParam' => ['a.id', 'a.title'], 'filterValue' => '*er']); | ||
| $accessor = new RequestArgumentAccess($requestStack); | ||
| $p = new Paginator($dispatcher, $accessor); | ||
| $view = $p->paginate($query, 1, 10); | ||
| $items = $view->getItems(); | ||
| $this->assertCount(2, $items); | ||
| $this->assertEquals('summer', $items[0]->getTitle()); | ||
| $this->assertEquals('winter', $items[1]->getTitle()); |
There was a problem hiding this comment.
This test code never did what it was supposed to do – test a filterParam that is an array.
In fact, the FiltrationSubscriber would add the ORM\QuerySubscriber only on the first pass, and so we were always using (without noticing) the first RequestArgumentAccess instance where the filterParam is a scalar value.
In fact, the Symfony Request throws when trying to access a query parameter value that is not a scalar, as it was the case in this removed code.
mpdude
force-pushed
the
pass-argument-access
branch
from
a9f5b89
to
a5977de
Compare
garak
requested changes
Sep 25, 2024
tests/Test/Pager/Subscriber/Filtration/Doctrine/ORM/QueryTest.php
Outdated
Show resolved
Hide resolved
|
@garak thank you for your feedback! I've addressed the objections. |
garak
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible for
knp_pager.itemsevent subscribers to access the pagination parameters, without having to be wired up by a dedicatedknp_pager.beforehandler.